Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 389e4e04 authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller
Browse files

qlcnic: fix a timeout loop 



The problem here is that at the end of the loop we test for if
idc->vnic_wait_limit is zero, but since idc->vnic_wait_limit-- is a
post-op, it actually ends up set to (u8)-1.  I have fixed this by
moving the decrement inside the loop.

Fixes: 486a5bc7 ('qlcnic: Add support for 83xx suspend and resume.')
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent fe0be35e

drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_vnic.c

+2 −1
Original line number Diff line number Diff line
@@ -246,7 +246,8 @@ int qlcnic_83xx_check_vnic_state(struct qlcnic_adapter *adapter) 
	u32 state;



	state = QLCRDX(ahw, QLC_83XX_VNIC_STATE);

	while (state != QLCNIC_DEV_NPAR_OPER && idc->vnic_wait_limit--) {

	while (state != QLCNIC_DEV_NPAR_OPER && idc->vnic_wait_limit) {

		idc->vnic_wait_limit--;

		msleep(1000);

		state = QLCRDX(ahw, QLC_83XX_VNIC_STATE);

	}