Commit fe0be35e authored Dec 15, 2015 by Dan Carpenter Committed by David S. Miller Dec 15, 2015

sfc: fix a timeout loop



We test for if "tries" is zero at the end but "tries--" is a post-op so
it will end with "tries" set to -1.  I have changed it to a pre-op
instead.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 351434c6

drivers/net/ethernet/sfc/txc43128_phy.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -418,7 +418,7 @@ static void txc_reset_logic_mmd(struct efx_nic *efx, int mmd)

		val \|= (1 << TXC_GLCMD_LMTSWRST_LBN);
		efx_mdio_write(efx, mmd, TXC_GLRGS_GLCMD, val);
		while (tries--) {
		while (--tries) {
		val = efx_mdio_read(efx, mmd, TXC_GLRGS_GLCMD);
		if (!(val & (1 << TXC_GLCMD_LMTSWRST_LBN)))
		break;