Commit 1c738b6a authored Mar 11, 2019 by Ajay Agarwal

usb: gadget: f_fs: Queue request after setting is_busy flag



Currently the driver queues OUT EP request after ensuring that
is_busy flag is false, and then sets it true. It might be
possible that the queued request is completed before the
execution reaches next line to set is_busy to true. As a result,
is_busy remains true even after successful completion and no
further request is queued.
Fix this by first setting is_busy to true and then queueing the
request.

Change-Id: I87fce4e2cc94be8e6b6fb63fb1fc9afb9cf0d005
Signed-off-by: Ajay Agarwal <ajaya@codeaurora.org>

parent e764712f

drivers/usb/gadget/function/f_fs.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -988,13 +988,14 @@ retry:
		* still busy.
		*/
		if (!(io_data->read && ep->is_busy)) {
		ret = usb_ep_queue(ep->ep, req, GFP_ATOMIC);
		ep->is_busy = true;
		ret = usb_ep_queue(ep->ep, req, GFP_ATOMIC);
		}

		spin_unlock_irq(&epfile->ffs->eps_lock);

		if (unlikely(ret < 0)) {
		ep->is_busy = false;
		ret = -EIO;
		} else if (unlikely(
		wait_for_completion_interruptible(done))) {