Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 025be74c authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: ps3: Use WARN_ON() instead of BUG_ON() 



BUG_ON() is rather useless for debugging as it leads to panic().
Use WARN_ON() and handle the error cases accordingly.

Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 29fa9578

sound/ppc/snd_ps3.c

+4 −2
Original line number Diff line number Diff line
@@ -933,8 +933,10 @@ static int snd_ps3_driver_probe(struct ps3_system_bus_device *dev) 
	int i, ret;

	u64 lpar_addr, lpar_size;



	BUG_ON(!firmware_has_feature(FW_FEATURE_PS3_LV1));

	BUG_ON(dev->match_id != PS3_MATCH_ID_SOUND);

	if (WARN_ON(!firmware_has_feature(FW_FEATURE_PS3_LV1)))

		return -ENODEV;

	if (WARN_ON(dev->match_id != PS3_MATCH_ID_SOUND))

		return -ENODEV;



	the_card.ps3_dev = dev;