Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 29fa9578 authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: ctxfi: Use WARN_ON() instead of BUG_ON() 



BUG_ON() is rather useless for debugging as it leads to panic().
Use WARN_ON() and handle the error cases accordingly.

Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 791b3f59

sound/pci/ctxfi/cthardware.c

+4 −2
Original line number Diff line number Diff line
@@ -69,7 +69,8 @@ unsigned int get_field(unsigned int data, unsigned int field) 
{

	int i;



	BUG_ON(!field);

	if (WARN_ON(!field))

		return 0;

	/* @field should always be greater than 0 */

	for (i = 0; !(field & (1 << i)); )

		i++;
@@ -81,7 +82,8 @@ void set_field(unsigned int *data, unsigned int field, unsigned int value) 
{

	int i;



	BUG_ON(!field);

	if (WARN_ON(!field))

		return;

	/* @field should always be greater than 0 */

	for (i = 0; !(field & (1 << i)); )

		i++;