Commit f7c01f9b authored Jan 27, 2015 by Ingrid Gallardo

msm: mdss: avoid overlay queue for a dirty pipe



During pipe setup, if a failure happens, the pipe
is marked as invalid and an error is returned to
the caller; it is the caller responsibility to honor
the failure and avoid an overlay play in the invalid
configuration. Anyways in order to prevent
configuration problems that can lead to underruns
due a wrong sequence by the caller, add a check
to print a warning and return an error if an
overlay play with an invalid pipe is called.

Change-Id: Ib2497b20eb4117bca8a94c30d3ef3b87ddb79fde
Signed-off-by: Ingrid Gallardo <ingridg@codeaurora.org>

parent d6415d1a

drivers/video/msm/mdss/mdss_mdp_overlay.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -1953,6 +1953,11 @@ static int mdss_mdp_overlay_queue(struct msm_fb_data_type *mfd,
		return -ENODEV;
		}

		if (pipe->dirty) {
		pr_warn("dirty pipe, will not queue pipe pnum=%d\n", pipe->num);
		return -ENODEV;
		}

		ret = mdss_mdp_pipe_map(pipe);
		if (IS_ERR_VALUE(ret)) {
		pr_err("Unable to map used pipe%d ndx=%x\n",