Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e62e80dc authored by Shantanu Jain's avatar Shantanu Jain
Browse files

input: touchscreen: Correct return value check in Goodix driver 



Correct return value check of gtp_read_fw_version, called in probe
of the Goodix driver. The return value is actually the number of
registers read through gtp_i2c_read() function call.
Also change the error message of gtp_check_product_id.

Change-Id: I0b643e250a487f08a19555237802b020b0873d1a
Signed-off-by: default avatarShantanu Jain <shjain@codeaurora.org>
parent 4a149ed1

drivers/input/touchscreen/gt9xx/gt9xx.c

+2 −2
Original line number Diff line number Diff line
@@ -1065,7 +1065,7 @@ static int gtp_check_product_id(struct i2c_client *client) 


	ret = gtp_i2c_read(client, buf, sizeof(buf));

	if (ret < 0) {

		dev_err(&client->dev, "GTP read version failed.\n");

		dev_err(&client->dev, "GTP read product_id failed.\n");

		return -EIO;

	}
@@ -1755,7 +1755,7 @@ static int goodix_ts_probe(struct i2c_client *client, 
		dev_info(&client->dev, "GTP works in interrupt mode.\n");



	ret = gtp_read_fw_version(client, &version_info);

	if (ret != 0)

	if (ret != 2)

		dev_err(&client->dev, "GTP firmware version read failed.\n");



	ret = gtp_check_product_id(client);