Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cdd6914b authored by Rohit Gupta's avatar Rohit Gupta
Browse files

cpufreq: interactive: Remove trace event from idle_start handler 



Removed the trace_cpufreq_interactive_idle_start.
Also fix a crash resulting from accessing NULL policy before taking
the pcpu->enable_sem lock. The policy can be NULL if the core is
hotplugged out before the enable_sem lock is taken.

Change-Id: I7e2809cc016b3b383a44cdf3c697013e2d2b5417
Signed-off-by: default avatarRohit Gupta <rohgup@codeaurora.org>
parent 5d3d1ac3

drivers/cpufreq/cpufreq_interactive.c

+0 −3
Original line number Diff line number Diff line
@@ -508,7 +508,6 @@ static void cpufreq_interactive_idle_start(void) 
	struct cpufreq_interactive_cpuinfo *pcpu =

		&per_cpu(cpuinfo, smp_processor_id());

	int pending;

	int cpu = pcpu->policy->cpu;

	u64 now;



	if (!down_read_trylock(&pcpu->enable_sem))
@@ -537,8 +536,6 @@ static void cpufreq_interactive_idle_start(void) 
				(now - pcpu->hispeed_validate_time) >

							MIN_BUSY_TIME) {

				pcpu->floor_validate_time = now;

				trace_cpufreq_interactive_idle_start(cpu,

					pcpu->target_freq, pcpu->policy->cur);

			}



		}

include/trace/events/cpufreq_interactive.h

+0 −6
Original line number Diff line number Diff line
@@ -34,12 +34,6 @@ DEFINE_EVENT(set, cpufreq_interactive_setspeed, 
	TP_ARGS(cpu_id, targfreq, actualfreq)

);



DEFINE_EVENT(set, cpufreq_interactive_idle_start,

	TP_PROTO(u32 cpu_id, unsigned long targfreq,

	     unsigned long actualfreq),

	TP_ARGS(cpu_id, targfreq, actualfreq)

);



DECLARE_EVENT_CLASS(loadeval,

	    TP_PROTO(unsigned long cpu_id, unsigned long load,

		     unsigned long curtarg, unsigned long curactual,