Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b22f36a4 authored by Benet Clark's avatar Benet Clark
Browse files

msm: mdss: Move histogram complete_all after hist interrupts disabled 



Previously, complete_all was called during histogram disablement before
the histogram interrupts were disabled, which can lead to issues if an
interrupt comes in between complete_all and interrupt disablement. Now,
complete_all is called afterwards, which guarantees no more interrupts
will come.

Change-Id: I1910e59b27ae55dbb2ed89373e2af614ef6a9808
Signed-off-by: default avatarBenet Clark <benetc@codeaurora.org>
parent 2b979b24

drivers/video/msm/mdss/mdss_mdp_pp.c

+1 −1
Original line number Diff line number Diff line
@@ -3187,13 +3187,13 @@ static int pp_hist_disable(struct pp_hist_col_info *hist_info) 
		ret = -EINVAL;

		goto exit;

	}

	complete_all(&hist_info->comp);

	spin_lock_irqsave(&hist_info->hist_lock, flag);

	hist_info->col_en = false;

	hist_info->col_state = HIST_UNKNOWN;

	spin_unlock_irqrestore(&hist_info->hist_lock, flag);

	mdss_mdp_hist_intr_req(&mdata->hist_intr,

				intr_mask << hist_info->intr_shift, false);

	complete_all(&hist_info->comp);

	/* if hist v2, make sure HW is unlocked */

	if (is_hist_v2)

		writel_relaxed(0, hist_info->base);