Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5ae82c90 authored by Jordan Crouse's avatar Jordan Crouse
Browse files

msm: kgsl: don't use sscanf() 



sscanf() is really hard to get right with different variable types
and it shouldn't be used when kstrtoul works just as well (and is
way safer).

Change-Id: Ic0dedbad56af5bbee4fc833701d8bc93b118efa9
Signed-off-by: default avatarJordan Crouse <jcrouse@codeaurora.org>
parent 7fabf7a6

drivers/gpu/msm/kgsl_mmu.c

+2 −2
Original line number Diff line number Diff line
@@ -138,12 +138,12 @@ kgsl_get_pagetable(unsigned long name) 
static struct kgsl_pagetable *

_get_pt_from_kobj(struct kobject *kobj)

{

	unsigned long ptname;

	unsigned int ptname;



	if (!kobj)

		return NULL;



	if (sscanf(kobj->name, "%ld", &ptname) != 1)

	if (kstrtou32(kobj->name, 0, &ptname))

		return NULL;



	return kgsl_get_pagetable(ptname);

drivers/gpu/msm/kgsl_sharedmem.c

+2 −2
Original line number Diff line number Diff line
@@ -74,12 +74,12 @@ static struct kgsl_process_private * 
_get_priv_from_kobj(struct kobject *kobj)

{

	struct kgsl_process_private *private;

	unsigned long name;

	unsigned int name;



	if (!kobj)

		return NULL;



	if (sscanf(kobj->name, "%ld", &name) != 1)

	if (kstrtou32(kobj->name, 0, &name))

		return NULL;



	list_for_each_entry(private, &kgsl_driver.process_list, list) {