Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5a04a150 authored by Serban Constantinescu's avatar Serban Constantinescu Committed by Olav Haugan
Browse files

staging: android: binder: modify struct binder_write_read to use size_t 



This change mirrors the userspace operation where struct binder_write_read
members that specify the buffer size and consumed size are size_t elements.

The patch also fixes the binder_thread_write() and binder_thread_read()
functions prototypes to conform with the definition of binder_write_read.

The changes do not affect existing 32bit ABI.

Change-Id: I6d8b4a0f2a593e1866749509b2dce7f4016ea6b4
Signed-off-by: default avatarSerban Constantinescu <serban.constantinescu@arm.com>
Acked-by: default avatarArve Hjønnevåg <arve@android.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Git-commit: 397334fc2be6a7e2f77474bd2b24880efea007bf
Git-repo: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git


Signed-off-by: default avatarOlav Haugan <ohaugan@codeaurora.org>
parent be339a2c

drivers/staging/android/binder.c

+5 −5
Original line number Diff line number Diff line
@@ -1719,7 +1719,7 @@ err_no_context_mgr_node: 
}



int binder_thread_write(struct binder_proc *proc, struct binder_thread *thread,

			void __user *buffer, int size, signed long *consumed)

			void __user *buffer, size_t size, size_t *consumed)

{

	uint32_t cmd;

	void __user *ptr = buffer + *consumed;
@@ -2099,8 +2099,8 @@ static int binder_has_thread_work(struct binder_thread *thread) 


static int binder_thread_read(struct binder_proc *proc,

			      struct binder_thread *thread,

			      void  __user *buffer, int size,

			      signed long *consumed, int non_block)

			      void  __user *buffer, size_t size,

			      size_t *consumed, int non_block)

{

	void __user *ptr = buffer + *consumed;

	void __user *end = buffer + size;
@@ -2597,7 +2597,7 @@ static long binder_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) 
			goto err;

		}

		binder_debug(BINDER_DEBUG_READ_WRITE,

			     "%d:%d write %ld at %08lx, read %ld at %08lx\n",

			     "%d:%d write %zd at %08lx, read %zd at %08lx\n",

			     proc->pid, thread->pid, bwr.write_size,

			     bwr.write_buffer, bwr.read_size, bwr.read_buffer);
@@ -2623,7 +2623,7 @@ static long binder_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) 
			}

		}

		binder_debug(BINDER_DEBUG_READ_WRITE,

			     "%d:%d wrote %ld of %ld, read return %ld of %ld\n",

			     "%d:%d wrote %zd of %zd, read return %zd of %zd\n",

			     proc->pid, thread->pid, bwr.write_consumed, bwr.write_size,

			     bwr.read_consumed, bwr.read_size);

		if (copy_to_user(ubuf, &bwr, sizeof(bwr))) {

drivers/staging/android/binder.h

+4 −4
Original line number Diff line number Diff line
@@ -67,11 +67,11 @@ struct flat_binder_object { 
 */



struct binder_write_read {

	signed long	write_size;	/* bytes to write */

	signed long	write_consumed;	/* bytes consumed by driver */

	size_t write_size;	/* bytes to write */

	size_t write_consumed;	/* bytes consumed by driver */

	unsigned long	write_buffer;

	signed long	read_size;	/* bytes to read */

	signed long	read_consumed;	/* bytes consumed by driver */

	size_t read_size;	/* bytes to read */

	size_t read_consumed;	/* bytes consumed by driver */

	unsigned long	read_buffer;

};