Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

This project is archived. Its data is read-only.

Commit 4415e63b authored Nov 09, 2011 by Keith Packard

drm/i915: Module parameters using '-1' as default must be signed type



Testing i915_panel_use_ssc for the default value was broken, so the
driver would never autodetect the correct value.

Signed-off-by: Keith Packard <keithp@keithp.com>
Reviewed-by: Michel Alexandre Salim <salimma@fedoraproject.org>
Tested-by: Michel Alexandre Salim <salimma@fedoraproject.org>
Cc: stable@kernel.org

parent 9ca1d10d

drivers/gpu/drm/i915/i915_drv.c

+2 −2

Original line number	Original line	Diff line number	Diff line
	@@ -67,7 +67,7 @@ module_param_named(i915_enable_rc6, i915_enable_rc6, int, 0600);
	MODULE_PARM_DESC(i915_enable_rc6,		MODULE_PARM_DESC(i915_enable_rc6,
	"Enable power-saving render C-state 6 (default: true)");		"Enable power-saving render C-state 6 (default: true)");

	unsigned int i915_enable_fbc __read_mostly = -1;		int i915_enable_fbc __read_mostly = -1;
	module_param_named(i915_enable_fbc, i915_enable_fbc, int, 0600);		module_param_named(i915_enable_fbc, i915_enable_fbc, int, 0600);
	MODULE_PARM_DESC(i915_enable_fbc,		MODULE_PARM_DESC(i915_enable_fbc,
	"Enable frame buffer compression for power savings "		"Enable frame buffer compression for power savings "
	@@ -79,7 +79,7 @@ MODULE_PARM_DESC(lvds_downclock,
	"Use panel (LVDS/eDP) downclocking for power savings "		"Use panel (LVDS/eDP) downclocking for power savings "
	"(default: false)");		"(default: false)");

	unsigned int i915_panel_use_ssc __read_mostly = -1;		int i915_panel_use_ssc __read_mostly = -1;
	module_param_named(lvds_use_ssc, i915_panel_use_ssc, int, 0600);		module_param_named(lvds_use_ssc, i915_panel_use_ssc, int, 0600);
	MODULE_PARM_DESC(lvds_use_ssc,		MODULE_PARM_DESC(lvds_use_ssc,
	"Use Spread Spectrum Clock with panels [LVDS/eDP] "		"Use Spread Spectrum Clock with panels [LVDS/eDP] "

drivers/gpu/drm/i915/i915_drv.h

+2 −2

Original line number	Original line	Diff line number	Diff line
	@@ -1000,10 +1000,10 @@ extern int i915_panel_ignore_lid __read_mostly;
	extern unsigned int i915_powersave __read_mostly;		extern unsigned int i915_powersave __read_mostly;
	extern unsigned int i915_semaphores __read_mostly;		extern unsigned int i915_semaphores __read_mostly;
	extern unsigned int i915_lvds_downclock __read_mostly;		extern unsigned int i915_lvds_downclock __read_mostly;
	extern unsigned int i915_panel_use_ssc __read_mostly;		extern int i915_panel_use_ssc __read_mostly;
	extern int i915_vbt_sdvo_panel_type __read_mostly;		extern int i915_vbt_sdvo_panel_type __read_mostly;
	extern unsigned int i915_enable_rc6 __read_mostly;		extern unsigned int i915_enable_rc6 __read_mostly;
	extern unsigned int i915_enable_fbc __read_mostly;		extern int i915_enable_fbc __read_mostly;
	extern bool i915_enable_hangcheck __read_mostly;		extern bool i915_enable_hangcheck __read_mostly;

	extern int i915_suspend(struct drm_device *dev, pm_message_t state);		extern int i915_suspend(struct drm_device *dev, pm_message_t state);