Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 43691da4 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

UIO: fix race in device_create 



There is a race from when a device is created with device_create() and
then the drvdata is set with a call to dev_set_drvdata() in which a
sysfs file could be open, yet the drvdata will be NULL, causing all
sorts of bad things to happen.

This patch fixes the problem by using the new function,
device_create_drvdata().

Cc: Kay Sievers <kay.sievers@vrfy.org>
Cc: Hans J. Koch <hjk@linutronix.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 54d29ad3

drivers/uio/uio.c

+3 −4
Original line number Diff line number Diff line
@@ -649,15 +649,14 @@ int __uio_register_device(struct module *owner, 
	if (ret)

		goto err_get_minor;



	idev->dev = device_create(uio_class->class, parent,

				  MKDEV(uio_major, idev->minor),

	idev->dev = device_create_drvdata(uio_class->class, parent,

					  MKDEV(uio_major, idev->minor), idev,

					  "uio%d", idev->minor);

	if (IS_ERR(idev->dev)) {

		printk(KERN_ERR "UIO: device register failed\n");

		ret = PTR_ERR(idev->dev);

		goto err_device_create;

	}

	dev_set_drvdata(idev->dev, idev);



	ret = uio_dev_add_attributes(idev);

	if (ret)