Commit 54d29ad3 authored May 16, 2008 by Greg Kroah-Hartman

Power Supply: fix race in device_create



There is a race from when a device is created with device_create() and
then the drvdata is set with a call to dev_set_drvdata() in which a
sysfs file could be open, yet the drvdata will be NULL, causing all
sorts of bad things to happen.

This patch fixes the problem by using the new function,
device_create_drvdata().

Cc: Kay Sievers <kay.sievers@vrfy.org>
Cc: Anton Vorontsov <cbou@mail.ru>
Cc: David Woodhouse <dwmw2@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent 0b00fc58

drivers/power/power_supply_core.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -91,15 +91,13 @@ int power_supply_register(struct device parent, struct power_supply psy)
		{
		int rc = 0;

		psy->dev = device_create(power_supply_class, parent, 0,
		"%s", psy->name);
		psy->dev = device_create_drvdata(power_supply_class, parent, 0,
		psy, "%s", psy->name);
		if (IS_ERR(psy->dev)) {
		rc = PTR_ERR(psy->dev);
		goto dev_create_failed;
		}

		dev_set_drvdata(psy->dev, psy);

		INIT_WORK(&psy->changed_work, power_supply_changed_work);

		rc = power_supply_create_attrs(psy);