Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0730ae1d authored by Dolev Raviv's avatar Dolev Raviv
Browse files

Revert "block: prevent access to NULL pointer in req->part" 



This reverts commit f97d4f61.
Although this check prevents NULL reference, it hides the real problem.
Requests that wish to avoid statistics update have to disable the
REQ_IO_STAT flag, otherwise req->part is expected to be initialized.

Change-Id: I680b95ab9aa668612d948770347929ffde30aeab
Signed-off-by: default avatarDolev Raviv <draviv@codeaurora.org>
parent 163f46e7

block/blk-core.c

+3 −7
Original line number Diff line number Diff line
@@ -2099,11 +2099,8 @@ static void blk_account_io_completion(struct request *req, unsigned int bytes) 
		struct hd_struct *part;

		int cpu;



		part = req->part;

		if (!part)

			return;



		cpu = part_stat_lock();

		part = req->part;

		part_stat_add(cpu, part, sectors[rw], bytes >> 9);

		part_stat_unlock();

	}
@@ -2122,15 +2119,14 @@ static void blk_account_io_done(struct request *req) 
		struct hd_struct *part;

		int cpu;



		cpu = part_stat_lock();

		part = req->part;

		if (!req->part)

			return;



		cpu = part_stat_lock();

		part_stat_inc(cpu, part, ios[rw]);

		part_stat_add(cpu, part, ticks[rw], duration);

		part_round_stats(cpu, part);

		part_dec_in_flight(part, rw);



		hd_struct_put(part);

		part_stat_unlock();

	}