Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 67221a42 authored by Jiri Slaby's avatar Jiri Slaby Committed by James Bottomley
Browse files

[SCSI] lpfc: fix lock imbalances 



Stanse found that two error paths in lpfc_bsg_rport_els_cmp and
lpfc_issue_ct_rsp_cmp omits to unlock phba->ct_ev_lock. It is
because they wrongly unlock phba->hbalock instead. Fix that.

Signed-off-by: default avatarJiri Slaby <jslaby@suse.cz>
Acked-by: default avatarJames Smart <james.smart@emulex.com>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@suse.de>
parent 4ec3fdbe

drivers/scsi/lpfc/lpfc_bsg.c

+2 −2
Original line number Original line Diff line number Diff line
@@ -433,7 +433,7 @@ lpfc_bsg_rport_els_cmp(struct lpfc_hba *phba, 
	dd_data = cmdiocbq->context1;

	dd_data = cmdiocbq->context1;

	/* normal completion and timeout crossed paths, already done */

	/* normal completion and timeout crossed paths, already done */

	if (!dd_data) {

	if (!dd_data) {

		spin_unlock_irqrestore(&phba->hbalock, flags);

		spin_unlock_irqrestore(&phba->ct_ev_lock, flags);

		return;

		return;

	}

	}
@@ -1196,7 +1196,7 @@ lpfc_issue_ct_rsp_cmp(struct lpfc_hba *phba, 
	dd_data = cmdiocbq->context1;

	dd_data = cmdiocbq->context1;

	/* normal completion and timeout crossed paths, already done */

	/* normal completion and timeout crossed paths, already done */

	if (!dd_data) {

	if (!dd_data) {

		spin_unlock_irqrestore(&phba->hbalock, flags);

		spin_unlock_irqrestore(&phba->ct_ev_lock, flags);

		return;

		return;

	}

	}