Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4ec3fdbe authored by Jiri Slaby's avatar Jiri Slaby Committed by James Bottomley
Browse files

[SCSI] be2iscsi: fix lock imbalance 



Stanse found that one error path in mgmt_invalidate_icds omits to unlock
ctrl->mbox_lock. Fix that.

Added in 756d29c8 (Enable async mode for mcc rings)
where the spinlock was moved.

Signed-off-by: default avatarJiri Slaby <jslaby@suse.cz>
Acked-by: default avatarJayamohan Kallickal <jayamohank@serverengines.com>
Reviewed-by: default avatarMike Christie <michaelc@cs.wisc.edu>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@suse.de>
parent 229bab6b

drivers/scsi/be2iscsi/be_mgmt.c

+1 −0
Original line number Diff line number Diff line
@@ -169,6 +169,7 @@ unsigned char mgmt_invalidate_icds(struct beiscsi_hba *phba, 
		SE_DEBUG(DBG_LVL_1,

			 "Failed to allocate memory for"

			 "mgmt_invalidate_icds \n");

		spin_unlock(&ctrl->mbox_lock);

		return -1;

	}

	nonemb_cmd.size = sizeof(struct invalidate_commands_params_in);