Commit 8f355e5c authored Feb 25, 2014 by Edward Cree Committed by David S. Miller Feb 26, 2014

sfc: check for NULL efx->ptp_data in efx_ptp_event



If we receive a PTP event from the NIC when we haven't set up PTP state
in the driver, we attempt to read through a NULL pointer efx->ptp_data,
triggering a panic.

Signed-off-by: Edward Cree <ecree@solarflare.com>
Acked-by: Shradha Shah <sshah@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 9a9bfd03

drivers/net/ethernet/sfc/ptp.c

+7 −0

Original line number	Diff line number	Diff line
		@@ -1668,6 +1668,13 @@ void efx_ptp_event(struct efx_nic efx, efx_qword_t ev)
		struct efx_ptp_data *ptp = efx->ptp_data;
		int code = EFX_QWORD_FIELD(*ev, MCDI_EVENT_CODE);

		if (!ptp) {
		if (net_ratelimit())
		netif_warn(efx, drv, efx->net_dev,
		"Received PTP event but PTP not set up\n");
		return;
		}

		if (!ptp->enabled)
		return;