Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9a9bfd03 authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller
Browse files

net: tcp: use NET_INC_STATS() 



While LINUX_MIB_TCPSPURIOUS_RTX_HOSTQUEUES can only be incremented
in tcp_transmit_skb() from softirq (incoming message or timer
activation), it is better to use NET_INC_STATS() instead of
NET_INC_STATS_BH() as tcp_transmit_skb() can be called from process
context.

This will avoid copy/paste confusion when/if we want to add
other SNMP counters in tcp_transmit_skb()

Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Cc: Hannes Frederic Sowa <hannes@stressinduktion.org>
Cc: Florian Westphal <fw@strlen.de>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent a4572e0c

net/ipv4/tcp_output.c

+2 −2
Original line number Diff line number Diff line
@@ -864,7 +864,7 @@ static int tcp_transmit_skb(struct sock *sk, struct sk_buff *skb, int clone_it, 


		if (unlikely(skb->fclone == SKB_FCLONE_ORIG &&

			     fclone->fclone == SKB_FCLONE_CLONE))

			NET_INC_STATS_BH(sock_net(sk),

			NET_INC_STATS(sock_net(sk),

				      LINUX_MIB_TCPSPURIOUS_RTX_HOSTQUEUES);



		if (unlikely(skb_cloned(skb)))