Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4f8210f6 authored by Nicolin Chen's avatar Nicolin Chen Committed by Mark Brown
Browse files

ASoC: fsl_esai: Set PCRC and PRRC registers at the end of hw_params() 



According to Reference Manual -- ESAI Initialization chapter, as the
standard procedure of ESAI personal reset, the PCRC and PRRC registers
should be remained in its reset value and then configured after T/RCCR
and T/RCR configurations's done but before TE/RE's enabling.

So this patch moves PCRC and PRRC settings to the end of hw_params().

Signed-off-by: default avatarNicolin Chen <Guangyu.Chen@freescale.com>
Signed-off-by: default avatarMark Brown <broonie@linaro.org>
parent 57ebbcaf

sound/soc/fsl/fsl_esai.c

+5 −6
Original line number Diff line number Diff line
@@ -461,12 +461,6 @@ static int fsl_esai_startup(struct snd_pcm_substream *substream, 
	}



	if (!dai->active) {

		/* Reset Port C */

		regmap_update_bits(esai_priv->regmap, REG_ESAI_PRRC,

				   ESAI_PRRC_PDC_MASK, ESAI_PRRC_PDC(ESAI_GPIO));

		regmap_update_bits(esai_priv->regmap, REG_ESAI_PCRC,

				   ESAI_PCRC_PC_MASK, ESAI_PCRC_PC(ESAI_GPIO));



		/* Set synchronous mode */

		regmap_update_bits(esai_priv->regmap, REG_ESAI_SAICR,

				   ESAI_SAICR_SYNC, esai_priv->synchronous ?
@@ -526,6 +520,11 @@ static int fsl_esai_hw_params(struct snd_pcm_substream *substream, 


	regmap_update_bits(esai_priv->regmap, REG_ESAI_xCR(tx), mask, val);



	/* Remove ESAI personal reset by configuring ESAI_PCRC and ESAI_PRRC */

	regmap_update_bits(esai_priv->regmap, REG_ESAI_PRRC,

			   ESAI_PRRC_PDC_MASK, ESAI_PRRC_PDC(ESAI_GPIO));

	regmap_update_bits(esai_priv->regmap, REG_ESAI_PCRC,

			   ESAI_PCRC_PC_MASK, ESAI_PCRC_PC(ESAI_GPIO));

	return 0;

}