Commit ffdc307d authored Oct 24, 2015 by Julia Lawall Committed by Jacek Anaszewski Nov 03, 2015

leds: 88pm860x: add missing of_node_put

for_each_child_of_node performs an of_node_get on each iteration, so
a break out of the loop requires an of_node_put.

A simplified version of the semantic patch that fixes this problem is as
follows (http://coccinelle.lip6.fr

):

// <smpl>
@@
local idexpression n;
expression e,r;
@@

 for_each_child_of_node(r,n) {
   ...
(
   of_node_put(n);
|
   e = n
|
+  of_node_put(n);
?  break;
)
   ...
 }
... when != n
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>

parent 6cc76244

drivers/leds/leds-88pm860x.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -142,6 +142,7 @@ static int pm860x_led_dt_init(struct platform_device *pdev,
		of_property_read_u32(np, "marvell,88pm860x-iset",
		&iset);
		data->iset = PM8606_LED_CURRENT(iset);
		of_node_put(np);
		break;
		}
		}