Commit 6cc76244 authored Oct 24, 2015 by Julia Lawall Committed by Jacek Anaszewski Nov 03, 2015

leds: bcm6328: add missing of_node_put

for_each_available_child_of_node performs an of_node_get on each
iteration, so a break out of the loop requires an of_node_put.

A simplified version of the semantic patch that fixes this problem is as
follows (http://coccinelle.lip6.fr

):

// <smpl>
@@
expression root,e;
local idexpression child;
@@

 for_each_available_child_of_node(root, child) {
   ... when != of_node_put(child)
       when != e = child
(
   return child;
|
+  of_node_put(child);
?  return ...;
)
   ...
 }
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>

parent 4b6ba5e2

drivers/leds/leds-bcm6328.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -403,9 +403,11 @@ static int bcm6328_leds_probe(struct platform_device *pdev)
		rc = bcm6328_led(dev, child, reg, mem, lock,
		blink_leds, blink_delay);

		if (rc < 0)
		if (rc < 0) {
		of_node_put(child);
		return rc;
		}
		}

		return 0;
		}