Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fc0f8fc9 authored by Oliver Neukum's avatar Oliver Neukum Committed by Greg Kroah-Hartman
Browse files

USB: memory leak in iowarrior.c 



this is a classical memory leak in the ioctl handler. The buffer is simply
never freed. This fixes it the obvious way.

Signed-off-by: default avatarOliver Neukum <oneukum@suse.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 944dc184

drivers/usb/misc/iowarrior.c

+4 −3
Original line number Diff line number Diff line
@@ -495,8 +495,8 @@ static int iowarrior_ioctl(struct inode *inode, struct file *file, 


	/* verify that the device wasn't unplugged */

	if (!dev->present) {

		mutex_unlock(&dev->mutex);

		return -ENODEV;

		retval = -ENODEV;

		goto error_out;

	}



	dbg("%s - minor %d, cmd 0x%.4x, arg %ld", __func__, dev->minor, cmd,
@@ -579,9 +579,10 @@ static int iowarrior_ioctl(struct inode *inode, struct file *file, 
		retval = -ENOTTY;

		break;

	}



error_out:

	/* unlock the device */

	mutex_unlock(&dev->mutex);

	kfree(buffer);

	return retval;

}