Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 944dc184 authored by Oliver Neukum's avatar Oliver Neukum Committed by Greg Kroah-Hartman
Browse files

USB: ti serial driver sleeps with spinlock held 



you are submitting an URB with GFP_KERNEL holding a spinlock.
In this case the spinlock can be dropped earlier.

Signed-off-by: default avatarOliver Neukum <oneukum@suse.de>
Cc: Al Borchers <alborchers@steinerpoint.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 8cfbe7e6

drivers/usb/serial/ti_usb_3410_5052.c

+5 −3
Original line number Original line Diff line number Diff line
@@ -1555,15 +1555,17 @@ static int ti_restart_read(struct ti_port *tport, struct tty_struct *tty) 
	spin_lock_irqsave(&tport->tp_lock, flags);

	spin_lock_irqsave(&tport->tp_lock, flags);





	if (tport->tp_read_urb_state == TI_READ_URB_STOPPED) {

	if (tport->tp_read_urb_state == TI_READ_URB_STOPPED) {

		tport->tp_read_urb_state = TI_READ_URB_RUNNING;

		urb = tport->tp_port->read_urb;

		urb = tport->tp_port->read_urb;

		spin_unlock_irqrestore(&tport->tp_lock, flags);

		urb->complete = ti_bulk_in_callback;

		urb->complete = ti_bulk_in_callback;

		urb->context = tport;

		urb->context = tport;

		urb->dev = tport->tp_port->serial->dev;

		urb->dev = tport->tp_port->serial->dev;

		status = usb_submit_urb(urb, GFP_KERNEL);

		status = usb_submit_urb(urb, GFP_KERNEL);

	}

	} else  {

		tport->tp_read_urb_state = TI_READ_URB_RUNNING;

		tport->tp_read_urb_state = TI_READ_URB_RUNNING;



		spin_unlock_irqrestore(&tport->tp_lock, flags);

		spin_unlock_irqrestore(&tport->tp_lock, flags);

	}





	return status;

	return status;

}

}