Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f257b99b authored by Sven Eckelmann's avatar Sven Eckelmann Committed by Simon Wunderlich
Browse files

batman-adv: Place kref_get for orig_ifinfo near use 



It is hard to understand why the refcnt is increased when it isn't done
near the actual place the new reference is used. So using kref_get right
before the place which requires the reference and in the same function
helps to avoid accidental problems caused by incorrect reference counting.

Signed-off-by: default avatarSven Eckelmann <sven@narfation.org>
Signed-off-by: default avatarMarek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: default avatarSimon Wunderlich <sw@simonwunderlich.de>
parent 09537d18

net/batman-adv/originator.c

+1 −0
Original line number Diff line number Diff line
@@ -386,6 +386,7 @@ batadv_orig_ifinfo_new(struct batadv_orig_node *orig_node, 
	orig_ifinfo->if_outgoing = if_outgoing;

	INIT_HLIST_NODE(&orig_ifinfo->list);

	kref_init(&orig_ifinfo->refcount);



	kref_get(&orig_ifinfo->refcount);

	hlist_add_head_rcu(&orig_ifinfo->list,

			   &orig_node->ifinfo_list);