Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 09537d18 authored by Sven Eckelmann's avatar Sven Eckelmann Committed by Simon Wunderlich
Browse files

batman-adv: Place kref_get for orig_node_vlan near use 



It is hard to understand why the refcnt is increased when it isn't done
near the actual place the new reference is used. So using kref_get right
before the place which requires the reference and in the same function
helps to avoid accidental problems caused by incorrect reference counting.

Signed-off-by: default avatarSven Eckelmann <sven@narfation.org>
Signed-off-by: default avatarMarek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: default avatarSimon Wunderlich <sw@simonwunderlich.de>
parent 4c09a08b

net/batman-adv/originator.c

+1 −1
Original line number Diff line number Diff line
@@ -133,9 +133,9 @@ batadv_orig_node_vlan_new(struct batadv_orig_node *orig_node, 
		goto out;



	kref_init(&vlan->refcount);

	kref_get(&vlan->refcount);

	vlan->vid = vid;



	kref_get(&vlan->refcount);

	hlist_add_head_rcu(&vlan->list, &orig_node->vlan_list);



out: