Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ecf09117 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by David S. Miller
Browse files

net: vrf: avoid gcc-4.6 warning 



When building an allmodconfig kernel with gcc-4.6, we get a rather
odd warning:

drivers/net/vrf.c: In function ‘vrf_ip6_input_dst’:
drivers/net/vrf.c:964:3: error: initialized field with side-effects overwritten [-Werror]
drivers/net/vrf.c:964:3: error: (near initialization for ‘fl6’) [-Werror]

I have no idea what this warning is even trying to say, but it does
seem like a false positive. Reordering the initialization in to match
the structure definition gets rid of the warning, and might also avoid
whatever gcc thinks is wrong here.

Fixes: 9ff74384 ("net: vrf: Handle ipv6 multicast and link-local addresses")
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 4739df62

drivers/net/vrf.c

+3 −3
Original line number Diff line number Diff line
@@ -957,12 +957,12 @@ static void vrf_ip6_input_dst(struct sk_buff *skb, struct net_device *vrf_dev, 
{

	const struct ipv6hdr *iph = ipv6_hdr(skb);

	struct flowi6 fl6 = {

		.flowi6_iif     = ifindex,

		.flowi6_mark    = skb->mark,

		.flowi6_proto   = iph->nexthdr,

		.daddr          = iph->daddr,

		.saddr          = iph->saddr,

		.flowlabel      = ip6_flowinfo(iph),

		.flowi6_mark    = skb->mark,

		.flowi6_proto   = iph->nexthdr,

		.flowi6_iif     = ifindex,

	};

	struct net *net = dev_net(vrf_dev);

	struct rt6_info *rt6;