Commit 4739df62 authored Sep 12, 2017 by Himanshu Jha Committed by David S. Miller Sep 15, 2017

qed: remove unnecessary call to memset



call to memset to assign 0 value immediately after allocating
memory with kzalloc is unnecesaary as kzalloc allocates the memory
filled with 0 value.

Semantic patch used to resolve this issue:

@@
expression e,e2; constant c;
statement S;
@@

  e = kzalloc(e2, c);
  if(e == NULL) S
- memset(e, 0, e2);

Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
Acked-by: Sudarsana Kalluru <sudarsana.kalluru@cavium.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 23f48222

drivers/net/ethernet/qlogic/qed/qed_dcbx.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -1244,7 +1244,6 @@ int qed_dcbx_get_config_params(struct qed_hwfn *p_hwfn,
		if (!dcbx_info)
		return -ENOMEM;

		memset(dcbx_info, 0, sizeof(*dcbx_info));
		rc = qed_dcbx_query_params(p_hwfn, dcbx_info, QED_DCBX_OPERATIONAL_MIB);
		if (rc) {
		kfree(dcbx_info);