Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c2b04824 authored by Alasdair Kergon's avatar Alasdair Kergon Committed by Mike Snitzer
Browse files

dm ioctl: prevent rename to empty name or uuid 



A device-mapper device must always have a name consisting of a non-empty
string.  If the device also has a uuid, this similarly must not be an
empty string.

The DM_DEV_CREATE ioctl enforces these rules when the device is created,
but this patch is needed to enforce them when DM_DEV_RENAME is used to
change the name or uuid.

Reported-by: default avatarZdenek Kabelac <zkabelac@redhat.com>
Signed-off-by: default avatarAlasdair G Kergon <agk@redhat.com>
Signed-off-by: default avatarMike Snitzer <snitzer@redhat.com>
Acked-by: default avatarMikulas Patocka <mpatocka@redhat.com>
parent d6fc2042

drivers/md/dm-ioctl.c

+1 −1
Original line number Diff line number Diff line
@@ -877,7 +877,7 @@ static int dev_rename(struct dm_ioctl *param, size_t param_size) 
	unsigned change_uuid = (param->flags & DM_UUID_FLAG) ? 1 : 0;



	if (new_data < param->data ||

	    invalid_str(new_data, (void *) param + param_size) ||

	    invalid_str(new_data, (void *) param + param_size) || !*new_data ||

	    strlen(new_data) > (change_uuid ? DM_UUID_LEN - 1 : DM_NAME_LEN - 1)) {

		DMWARN("Invalid new mapped device name or uuid string supplied.");

		return -EINVAL;