Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d6fc2042 authored by Mike Snitzer's avatar Mike Snitzer
Browse files

dm thin: set pool read-only if breaking_sharing fails block allocation 



break_sharing() now handles an arbitrary alloc_data_block() error
the same way as provision_block(): marks pool read-only and errors the
cell.

Signed-off-by: default avatarMike Snitzer <snitzer@redhat.com>
Acked-by: default avatarJoe Thornber <ejt@redhat.com>
Signed-off-by: default avatarAlasdair G Kergon <agk@redhat.com>
parent 4fa5971a

drivers/md/dm-thin.c

+4 −2
Original line number Diff line number Diff line
@@ -1086,6 +1086,7 @@ static void break_sharing(struct thin_c *tc, struct bio *bio, dm_block_t block, 
{

	int r;

	dm_block_t data_block;

	struct pool *pool = tc->pool;



	r = alloc_data_block(tc, &data_block);

	switch (r) {
@@ -1095,13 +1096,14 @@ static void break_sharing(struct thin_c *tc, struct bio *bio, dm_block_t block, 
		break;



	case -ENOSPC:

		no_space(tc->pool, cell);

		no_space(pool, cell);

		break;



	default:

		DMERR_LIMIT("%s: alloc_data_block() failed: error = %d",

			    __func__, r);

		cell_error(tc->pool, cell);

		set_pool_mode(pool, PM_READ_ONLY);

		cell_error(pool, cell);

		break;

	}

}