Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b2d3afcf authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab
Browse files

[media] tda6655: get rid of get_state()/set_state() 



Those ops aren't used by any driver, with is weird. I suspect
that mantis_vb3030 driver were not working properly...

Anyway, now that the driver uses the set_parms, the DVB
frontend core should do the right thing.

Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
parent e417668d

drivers/media/dvb-frontends/tda665x.c

+0 −36
Original line number Original line Diff line number Diff line
@@ -66,28 +66,6 @@ static int tda665x_write(struct tda665x_state *state, u8 *buf, u8 length) 
	return err;

	return err;

}

}





static int tda665x_get_state(struct dvb_frontend *fe,

			     enum tuner_param param,

			     struct tuner_state *tstate)

{

	struct tda665x_state *state = fe->tuner_priv;

	int err = 0;



	switch (param) {

	case DVBFE_TUNER_FREQUENCY:

		tstate->frequency = state->frequency;

		break;

	case DVBFE_TUNER_BANDWIDTH:

		break;

	default:

		printk(KERN_ERR "%s: Unknown parameter (param=%d)\n", __func__, param);

		err = -EINVAL;

		break;

	}



	return err;

}



static int tda665x_get_frequency(struct dvb_frontend *fe, u32 *frequency)

static int tda665x_get_frequency(struct dvb_frontend *fe, u32 *frequency)

{

{

	struct tda665x_state *state = fe->tuner_priv;

	struct tda665x_state *state = fe->tuner_priv;
@@ -219,17 +197,6 @@ static int tda665x_set_params(struct dvb_frontend *fe) 
	return 0;

	return 0;

}

}





static int tda665x_set_state(struct dvb_frontend *fe,

			     enum tuner_param param,

			     struct tuner_state *tstate)

{

	if (param & DVBFE_TUNER_FREQUENCY)

		return  tda665x_set_frequency(fe, tstate->frequency);



	printk(KERN_ERR "%s: Unknown parameter (param=%d)\n", __func__, param);

	return -EINVAL;

}



static int tda665x_release(struct dvb_frontend *fe)

static int tda665x_release(struct dvb_frontend *fe)

{

{

	struct tda665x_state *state = fe->tuner_priv;

	struct tda665x_state *state = fe->tuner_priv;
@@ -240,9 +207,6 @@ static int tda665x_release(struct dvb_frontend *fe) 
}

}





static struct dvb_tuner_ops tda665x_ops = {

static struct dvb_tuner_ops tda665x_ops = {



	.set_state	= tda665x_set_state,

	.get_state	= tda665x_get_state,

	.get_status	= tda665x_get_status,

	.get_status	= tda665x_get_status,

	.set_params	= tda665x_set_params,

	.set_params	= tda665x_set_params,

	.get_frequency	= tda665x_get_frequency,

	.get_frequency	= tda665x_get_frequency,