Commit 844dfa1b authored Nov 14, 2017 by Dennis Dalessandro Committed by Greg Kroah-Hartman Feb 25, 2018

IB/hfi1: Initialize bth1 in 16B rc ack builder




[ Upstream commit 8935780b9f7bbad0f2eb5dd43f61ba7b509a1575 ]

It is possible the bth1 variable could be used uninitialized so going
ahead and giving it a default value.

Otherwise we leak stack memory to the network.

Fixes: 5b6cabb0 ("IB/hfi1: Add 16B RC/UC support")
Reviewed-by: Don Hiatt <don.hiatt@intel.com>
Signed-off-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 04521caa

drivers/infiniband/hw/hfi1/rc.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -815,7 +815,7 @@ static inline void hfi1_make_rc_ack_16B(struct rvt_qp *qp,
		struct hfi1_pportdata *ppd = ppd_from_ibp(ibp);
		struct hfi1_16b_header *hdr = &opa_hdr->opah;
		struct ib_other_headers *ohdr;
		u32 bth0, bth1;
		u32 bth0, bth1 = 0;
		u16 len, pkey;
		u8 becn = !!is_fecn;
		u8 l4 = OPA_16B_L4_IB_LOCAL;