Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6aeb75e6 authored by Johan Hovold's avatar Johan Hovold
Browse files

USB: serial: io_ti: fix div-by-zero in set_termios



Fix a division-by-zero in set_termios when debugging is enabled and a
high-enough speed has been requested so that the divisor value becomes
zero.

Instead of just fixing the offending debug statement, cap the baud rate
at the base as a zero divisor value also appears to crash the firmware.

Fixes: 1da177e4 ("Linux-2.6.12-rc2")
Cc: stable <stable@vger.kernel.org>     # 2.6.12
Reviewed-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
parent 26cede34
Loading
Loading
Loading
Loading
+4 −1
Original line number Diff line number Diff line
@@ -2336,8 +2336,11 @@ static void change_port_settings(struct tty_struct *tty,
	if (!baud) {
		/* pick a default, any default... */
		baud = 9600;
	} else
	} else {
		/* Avoid a zero divisor. */
		baud = min(baud, 461550);
		tty_encode_baud_rate(tty, baud, baud);
	}

	edge_port->baud_rate = baud;
	config->wBaudRate = (__u16)((461550L + baud/2) / baud);