Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 26cede34 authored by Johan Hovold's avatar Johan Hovold
Browse files

USB: serial: mct_u232: fix big-endian baud-rate handling 



Drop erroneous cpu_to_le32 when setting the baud rate, something which
corrupted the divisor on big-endian hosts.

Found using sparse:

	warning: incorrect type in argument 1 (different base types)
	    expected unsigned int [unsigned] [usertype] val
	    got restricted __le32 [usertype] <noident>

Fixes: af2ac1a0 ("USB: serial mct_usb232: move DMA buffers to heap")
Cc: stable <stable@vger.kernel.org>     # 2.6.34
Reviewed-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Acked-By: default avatarPete Zaitcev <zaitcev@yahoo.com>
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
parent ad0ccac7

drivers/usb/serial/mct_u232.c

+1 −1
Original line number Diff line number Diff line
@@ -189,7 +189,7 @@ static int mct_u232_set_baud_rate(struct tty_struct *tty, 
		return -ENOMEM;



	divisor = mct_u232_calculate_baud_rate(serial, value, &speed);

	put_unaligned_le32(cpu_to_le32(divisor), buf);

	put_unaligned_le32(divisor, buf);

	rc = usb_control_msg(serial->dev, usb_sndctrlpipe(serial->dev, 0),

				MCT_U232_SET_BAUD_RATE_REQUEST,

				MCT_U232_SET_REQUEST_TYPE,