Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5a63ddf6 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Tomi Valkeinen
Browse files

video: exynos: fix modular build 



The s6e8ax0 driver has a dependency on BACKLIGHT_CLASS_DEVICE,
which can be configured as a loadable module, so we have to
make the driver a tristate symbol as well, to avoid this error:

drivers/built-in.o: In function `s6e8ax0_probe':
:(.text+0x23a48): undefined reference to `devm_backlight_device_register'

This also means we get another error from a missing export, which
this fixes as well:

ERROR: "exynos_mipi_dsi_register_lcd_driver" [drivers/video/fbdev/exynos/s6e8ax0.ko] undefined!

The drivers are all written to be loadable modules already,
except the Kconfig options for that are missing, which makes
the patch really easy.

Finally, the EXYNOS_VIDEO option is turned into tristate as well
for good measure, as all framebuffer drivers should be configurable
as modules, though this change is not strictly necessary.

Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Reviewed-by: default avatarKrzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
parent 713fced8

drivers/video/fbdev/exynos/Kconfig

+3 −3
Original line number Diff line number Diff line
@@ -3,7 +3,7 @@ 
#



menuconfig EXYNOS_VIDEO

	bool "Exynos Video driver support"

	tristate "Exynos Video driver support"

	depends on ARCH_S5PV210 || ARCH_EXYNOS

	help

	  This enables support for EXYNOS Video device.
@@ -15,13 +15,13 @@ if EXYNOS_VIDEO 
#



config EXYNOS_MIPI_DSI

	bool "EXYNOS MIPI DSI driver support."

	tristate "EXYNOS MIPI DSI driver support."

	select GENERIC_PHY

	help

	  This enables support for MIPI-DSI device.



config EXYNOS_LCD_S6E8AX0

	bool "S6E8AX0 MIPI AMOLED LCD Driver"

	tristate "S6E8AX0 MIPI AMOLED LCD Driver"

	depends on EXYNOS_MIPI_DSI && BACKLIGHT_CLASS_DEVICE

	depends on (LCD_CLASS_DEVICE = y)

	default n

drivers/video/fbdev/exynos/Makefile

+4 −2
Original line number Diff line number Diff line
@@ -2,6 +2,8 @@ 
# Makefile for the exynos video drivers.

#



obj-$(CONFIG_EXYNOS_MIPI_DSI)		+= exynos_mipi_dsi.o exynos_mipi_dsi_common.o \

obj-$(CONFIG_EXYNOS_MIPI_DSI)		+= exynos-mipi-dsi-mod.o



exynos-mipi-dsi-mod-objs		+= exynos_mipi_dsi.o exynos_mipi_dsi_common.o \

					   exynos_mipi_dsi_lowlevel.o

obj-$(CONFIG_EXYNOS_LCD_S6E8AX0)	+= s6e8ax0.o

drivers/video/fbdev/exynos/exynos_mipi_dsi.c

+1 −0
Original line number Diff line number Diff line
@@ -263,6 +263,7 @@ int exynos_mipi_dsi_register_lcd_driver(struct mipi_dsim_lcd_driver *lcd_drv) 
	return 0;



}

EXPORT_SYMBOL_GPL(exynos_mipi_dsi_register_lcd_driver);



static struct mipi_dsim_ddi *exynos_mipi_dsi_bind_lcd_ddi(

						struct mipi_dsim_device *dsim,