Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 534284a0 authored by Pete Wyckoff's avatar Pete Wyckoff Committed by James Bottomley
Browse files

[SCSI] iscsi: always release crypto 



Unconditionally free crypto state, as it is always allocated during
TCP connection creation.  Without this, crypto structures leak and
crc32c module refcounts grow as connections are created and
destroyed.

Signed-off-by: default avatarPete Wyckoff <pw@osc.edu>
Signed-off-by: default avatarMike Christie <michaelc@cs.wisc.edu>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
parent 7ca63cb4

drivers/scsi/iscsi_tcp.c

+4 −11
Original line number Diff line number Diff line
@@ -1816,21 +1816,14 @@ iscsi_tcp_conn_destroy(struct iscsi_cls_conn *cls_conn) 
{

	struct iscsi_conn *conn = cls_conn->dd_data;

	struct iscsi_tcp_conn *tcp_conn = conn->dd_data;

	int digest = 0;



	if (conn->hdrdgst_en || conn->datadgst_en)

		digest = 1;



	iscsi_tcp_release_conn(conn);

	iscsi_conn_teardown(cls_conn);



	/* now free tcp_conn */

	if (digest) {

	if (tcp_conn->tx_hash.tfm)

		crypto_free_hash(tcp_conn->tx_hash.tfm);

	if (tcp_conn->rx_hash.tfm)

		crypto_free_hash(tcp_conn->rx_hash.tfm);

	}



	kfree(tcp_conn);

}