Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4318ad77 authored by Julia Lawall's avatar Julia Lawall Committed by Guenter Roeck
Browse files

hwmon: (k8temp) use permission-specific DEVICE_ATTR variants 



Use DEVICE_ATTR_RO for read-only attributes. This simplifies the source
code, improves readbility, and reduces the chance of inconsistencies.

The conversion was done automatically using coccinelle. It was validated
by compiling both the old and the new source code and comparing its text,
data, and bss size.

Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
[groeck: Updated description]
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 3776c835

drivers/hwmon/k8temp.c

+2 −2
Original line number Diff line number Diff line
@@ -100,7 +100,7 @@ static struct k8temp_data *k8temp_update_device(struct device *dev) 
 * Sysfs stuff

 */



static ssize_t show_name(struct device *dev, struct device_attribute

static ssize_t name_show(struct device *dev, struct device_attribute

			 *devattr, char *buf)

{

	struct k8temp_data *data = dev_get_drvdata(dev);
@@ -133,7 +133,7 @@ static SENSOR_DEVICE_ATTR_2(temp1_input, S_IRUGO, show_temp, NULL, 0, 0); 
static SENSOR_DEVICE_ATTR_2(temp2_input, S_IRUGO, show_temp, NULL, 0, 1);

static SENSOR_DEVICE_ATTR_2(temp3_input, S_IRUGO, show_temp, NULL, 1, 0);

static SENSOR_DEVICE_ATTR_2(temp4_input, S_IRUGO, show_temp, NULL, 1, 1);

static DEVICE_ATTR(name, S_IRUGO, show_name, NULL);

static DEVICE_ATTR_RO(name);



static const struct pci_device_id k8temp_ids[] = {

	{ PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_K8_NB_MISC) },