Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3776c835 authored by Julia Lawall's avatar Julia Lawall Committed by Guenter Roeck
Browse files

hwmon: (sch5627) use permission-specific DEVICE_ATTR variants 



Use DEVICE_ATTR_RO for read-only attributes. This simplifies the source
code, improves readbility, and reduces the chance of inconsistencies.

The conversion was done automatically using coccinelle. It was validated
by compiling both the old and the new source code and comparing its text,
data, and bss size.

Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
[groeck: Updated description]
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent eabb6f15

drivers/hwmon/sch5627.c

+2 −2
Original line number Diff line number Diff line
@@ -205,7 +205,7 @@ static int reg_to_rpm(u16 reg) 
	return 5400540 / reg;

}



static ssize_t show_name(struct device *dev, struct device_attribute *devattr,

static ssize_t name_show(struct device *dev, struct device_attribute *devattr,

	char *buf)

{

	return snprintf(buf, PAGE_SIZE, "%s\n", DEVNAME);
@@ -326,7 +326,7 @@ static ssize_t show_in_label(struct device *dev, struct device_attribute 
			SCH5627_IN_LABELS[attr->index]);

}



static DEVICE_ATTR(name, S_IRUGO, show_name, NULL);

static DEVICE_ATTR_RO(name);

static SENSOR_DEVICE_ATTR(temp1_input, S_IRUGO, show_temp, NULL, 0);

static SENSOR_DEVICE_ATTR(temp2_input, S_IRUGO, show_temp, NULL, 1);

static SENSOR_DEVICE_ATTR(temp3_input, S_IRUGO, show_temp, NULL, 2);