Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 396e287f authored by Vitaly Kuznetsov's avatar Vitaly Kuznetsov Committed by Greg Kroah-Hartman
Browse files

Drivers: hv: get rid of timeout in vmbus_open() 



vmbus_teardown_gpadl() can result in infinite wait when it is called on 5
second timeout in vmbus_open(). The issue is caused by the fact that gpadl
teardown operation won't ever succeed for an opened channel and the timeout
isn't always enough. As a guest, we can always trust the host to respond to
our request (and there is nothing we can do if it doesn't).

Signed-off-by: default avatarVitaly Kuznetsov <vkuznets@redhat.com>
Signed-off-by: default avatarK. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 7cc80c98

drivers/hv/channel.c

+1 −6
Original line number Diff line number Diff line
@@ -73,7 +73,6 @@ int vmbus_open(struct vmbus_channel *newchannel, u32 send_ringbuffer_size, 
	void *in, *out;

	unsigned long flags;

	int ret, err = 0;

	unsigned long t;

	struct page *page;



	spin_lock_irqsave(&newchannel->lock, flags);
@@ -183,11 +182,7 @@ int vmbus_open(struct vmbus_channel *newchannel, u32 send_ringbuffer_size, 
		goto error1;

	}



	t = wait_for_completion_timeout(&open_info->waitevent, 5*HZ);

	if (t == 0) {

		err = -ETIMEDOUT;

		goto error1;

	}

	wait_for_completion(&open_info->waitevent);



	spin_lock_irqsave(&vmbus_connection.channelmsg_lock, flags);

	list_del(&open_info->msglistentry);