Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7cc80c98 authored by Vitaly Kuznetsov's avatar Vitaly Kuznetsov Committed by Greg Kroah-Hartman
Browse files

Drivers: hv: don't leak memory in vmbus_establish_gpadl() 



In some cases create_gpadl_header() allocates submessages but we never
free them.

Signed-off-by: default avatarVitaly Kuznetsov <vkuznets@redhat.com>
Signed-off-by: default avatarK. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 4d637632

drivers/hv/channel.c

+5 −1
Original line number Original line Diff line number Diff line
@@ -388,7 +388,7 @@ int vmbus_establish_gpadl(struct vmbus_channel *channel, void *kbuffer, 
	struct vmbus_channel_gpadl_header *gpadlmsg;

	struct vmbus_channel_gpadl_header *gpadlmsg;

	struct vmbus_channel_gpadl_body *gpadl_body;

	struct vmbus_channel_gpadl_body *gpadl_body;

	struct vmbus_channel_msginfo *msginfo = NULL;

	struct vmbus_channel_msginfo *msginfo = NULL;

	struct vmbus_channel_msginfo *submsginfo;

	struct vmbus_channel_msginfo *submsginfo, *tmp;

	struct list_head *curr;

	struct list_head *curr;

	u32 next_gpadl_handle;

	u32 next_gpadl_handle;

	unsigned long flags;

	unsigned long flags;
@@ -445,6 +445,10 @@ int vmbus_establish_gpadl(struct vmbus_channel *channel, void *kbuffer, 
	spin_lock_irqsave(&vmbus_connection.channelmsg_lock, flags);

	spin_lock_irqsave(&vmbus_connection.channelmsg_lock, flags);

	list_del(&msginfo->msglistentry);

	list_del(&msginfo->msglistentry);

	spin_unlock_irqrestore(&vmbus_connection.channelmsg_lock, flags);

	spin_unlock_irqrestore(&vmbus_connection.channelmsg_lock, flags);

	list_for_each_entry_safe(submsginfo, tmp, &msginfo->submsglist,

				 msglistentry) {

		kfree(submsginfo);

	}





	kfree(msginfo);

	kfree(msginfo);

	return ret;

	return ret;