Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2e774ac2 authored by Sven Eckelmann's avatar Sven Eckelmann Committed by Simon Wunderlich
Browse files

batman-adv: Place kref_get for neigh_ifinfo near use 



It is hard to understand why the refcnt is increased when it isn't done
near the actual place the new reference is used. So using kref_get right
before the place which requires the reference and in the same function
helps to avoid accidental problems caused by incorrect reference counting.

Signed-off-by: default avatarSven Eckelmann <sven@narfation.org>
Signed-off-by: default avatarMarek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: default avatarSimon Wunderlich <sw@simonwunderlich.de>
parent 23f55485

net/batman-adv/originator.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -460,9 +460,9 @@ batadv_neigh_ifinfo_new(struct batadv_neigh_node *neigh, 




	INIT_HLIST_NODE(&neigh_ifinfo->list);

	INIT_HLIST_NODE(&neigh_ifinfo->list);

	kref_init(&neigh_ifinfo->refcount);

	kref_init(&neigh_ifinfo->refcount);

	kref_get(&neigh_ifinfo->refcount);

	neigh_ifinfo->if_outgoing = if_outgoing;

	neigh_ifinfo->if_outgoing = if_outgoing;





	kref_get(&neigh_ifinfo->refcount);

	hlist_add_head_rcu(&neigh_ifinfo->list, &neigh->ifinfo_list);

	hlist_add_head_rcu(&neigh_ifinfo->list, &neigh->ifinfo_list);





out:

out: