Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 23f55485 authored by Sven Eckelmann's avatar Sven Eckelmann Committed by Simon Wunderlich
Browse files

batman-adv: Place kref_get for tt_orig_list_entry near use 



It is hard to understand why the refcnt is increased when it isn't done
near the actual place the new reference is used. So using kref_get right
before the place which requires the reference and in the same function
helps to avoid accidental problems caused by incorrect reference counting.

Signed-off-by: default avatarSven Eckelmann <sven@narfation.org>
Signed-off-by: default avatarMarek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: default avatarSimon Wunderlich <sw@simonwunderlich.de>
parent f257b99b

net/batman-adv/translation-table.c

+1 −1
Original line number Diff line number Diff line
@@ -1567,9 +1567,9 @@ batadv_tt_global_orig_entry_add(struct batadv_tt_global_entry *tt_global, 
	orig_entry->orig_node = orig_node;

	orig_entry->ttvn = ttvn;

	kref_init(&orig_entry->refcount);

	kref_get(&orig_entry->refcount);



	spin_lock_bh(&tt_global->list_lock);

	kref_get(&orig_entry->refcount);

	hlist_add_head_rcu(&orig_entry->list,

			   &tt_global->orig_list);

	spin_unlock_bh(&tt_global->list_lock);