Commit 1ad866e7 authored Sep 04, 2013 by Larry Finger Committed by Greg Kroah-Hartman Sep 17, 2013

staging: r8188eu: Fix smatch warnings in core/rtw_xmit.c

Smatch reports the following:
drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c:1500 hal_EfusePgPacketWriteData() info: ignoring unreachable code.
drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c:2188 Hal_ReadTxPowerInfo88E() error: buffer overflow 'pHalData->Index24G_CCK_Base[rfPath]' 14 <= 14
drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c:2190 Hal_ReadTxPowerInfo88E() error: buffer overflow 'pHalData->Index24G_BW40_Base[rfPath]' 14 <= 14
drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c:2196 Hal_ReadTxPowerInfo88E() error: buffer overflow 'pHalData->Index24G_CCK_Base[rfPath]' 14 <= 14
drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c:2197 Hal_ReadTxPowerInfo88E() error: buffer overflow 'pHalData->Index24G_BW40_Base[rfPath]' 14 <= 14

The first of these is trivial. The rest are due to an off-by-one error
in a loop over the channels.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent f23e3c1e

drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -1479,7 +1479,6 @@ static bool hal_EfusePgPacketWrite1ByteHeader(struct adapter *pAdapter, u8 efuse

		static bool hal_EfusePgPacketWriteData(struct adapter pAdapter, u8 efuseType, u16 pAddr, struct pgpkt *pTargetPkt, bool bPseudoTest)
		{
		bool bRet = false;
		u16 efuse_addr = *pAddr;
		u8 badworden = 0;
		u32 PgWriteSuccess = 0;
		@@ -1497,7 +1496,6 @@ static bool hal_EfusePgPacketWriteData(struct adapter *pAdapter, u8 efuseType, u
		else
		return true;
		}
		return bRet;
		}

		static bool
		@@ -2182,7 +2180,7 @@ void Hal_ReadTxPowerInfo88E(struct adapter padapter, u8 PROMContent, bool Auto
		pHalData->bTXPowerDataReadFromEEPORM = true;

		for (rfPath = 0; rfPath < pHalData->NumTotalRFPath; rfPath++) {
		for (ch = 0; ch <= CHANNEL_MAX_NUMBER; ch++) {
		for (ch = 0; ch < CHANNEL_MAX_NUMBER; ch++) {
		bIn24G = Hal_GetChnlGroup88E(ch, &group);
		if (bIn24G) {
		pHalData->Index24G_CCK_Base[rfPath][ch] = pwrInfo24G.IndexCCK_Base[rfPath][group];