Commit f23e3c1e authored Sep 04, 2013 by Larry Finger Committed by Greg Kroah-Hartman Sep 17, 2013

staging: r8188eu: Fix smatch warnings for hal/rtl8188e_phycfg.c

Smatch reports the following:
drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c:857 getTxPowerIndex88E() error: buffer overflow 'pHalData->BW20_24G_Diff' 2 <= 2
drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c:864 getTxPowerIndex88E() error: buffer overflow 'pHalData->BW20_24G_Diff' 2 <= 2

The array in question is large enough to handle RADIO_PATH_X, where X is A or B.
The lines in question refer to RADIO_PATH_C, which is defined as 2.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 22fd8b77

drivers/staging/rtl8188eu/include/Hal8188EPhyCfg.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -75,7 +75,7 @@ enum rf_radio_path {

		#define MAX_PG_GROUP 13

		#define RF_PATH_MAX 2
		#define RF_PATH_MAX 3
		#define MAX_RF_PATH RF_PATH_MAX
		#define MAX_TX_COUNT 4 /* path numbers */

drivers/staging/rtl8188eu/include/odm.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -950,7 +950,7 @@ struct odm_dm_struct {
		struct timer_list FastAntTrainingTimer;
		}; /* DM_Dynamic_Mechanism_Structure */

		#define ODM_RF_PATH_MAX 2
		#define ODM_RF_PATH_MAX 3

		enum ODM_RF_RADIO_PATH {
		ODM_RF_PATH_A = 0, /* Radio Path A */