Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0b08273c authored by Markus Elfring's avatar Markus Elfring Committed by Mike Marshall
Browse files

orangefs: Adjust three checks for null pointers 



MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The script “checkpatch.pl” pointed information out like the following.

Comparison to NULL could be written !…

Thus fix affected source code places.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: default avatarMike Marshall <hubcap@omnibond.com>
parent 5e273a0e

fs/orangefs/acl.c

+1 −1
Original line number Diff line number Diff line
@@ -35,7 +35,7 @@ struct posix_acl *orangefs_get_acl(struct inode *inode, int type) 
	 * I don't do that for now.

	 */

	value = kmalloc(ORANGEFS_MAX_XATTR_VALUELEN, GFP_KERNEL);

	if (value == NULL)

	if (!value)

		return ERR_PTR(-ENOMEM);



	gossip_debug(GOSSIP_ACL_DEBUG,

fs/orangefs/xattr.c

+2 −2
Original line number Diff line number Diff line
@@ -239,7 +239,7 @@ int orangefs_inode_setxattr(struct inode *inode, const char *name, 
	internal_flag = convert_to_internal_xattr_flags(flags);



	/* This is equivalent to a removexattr */

	if (size == 0 && value == NULL) {

	if (size == 0 && !value) {

		gossip_debug(GOSSIP_XATTR_DEBUG,

			     "removing xattr (%s)\n",

			     name);
@@ -311,7 +311,7 @@ ssize_t orangefs_listxattr(struct dentry *dentry, char *buffer, size_t size) 
	int i = 0;

	int returned_count = 0;



	if (size > 0 && buffer == NULL) {

	if (size > 0 && !buffer) {

		gossip_err("%s: bogus NULL pointers\n", __func__);

		return -EINVAL;

	}