Commit 5e273a0e authored Aug 17, 2017 by Markus Elfring Committed by Mike Marshall Sep 14, 2017

orangefs: Use kcalloc() in orangefs_prepare_cdm_array()



* A multiplication for the size determination of a memory allocation
  indicated that an array data structure should be processed.
  Thus use the corresponding function "kcalloc".

  This issue was detected by using the Coccinelle software.

* Replace the specification of a data structure by a pointer dereference
  to make the corresponding size determination a bit safer according to
  the Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Mike Marshall <hubcap@omnibond.com>

parent 07a25853

fs/orangefs/orangefs-debugfs.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -571,9 +571,7 @@ static int orangefs_prepare_cdm_array(char *debug_array_string)
		goto out;
		}

		cdm_array =
		kzalloc(cdm_element_count * sizeof(struct client_debug_mask),
		GFP_KERNEL);
		cdm_array = kcalloc(cdm_element_count, sizeof(*cdm_array), GFP_KERNEL);
		if (!cdm_array) {
		rc = -ENOMEM;
		goto out;