Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ffabad4a authored by Ma Ke's avatar Ma Ke Committed by Greg Kroah-Hartman
Browse files

drm/nouveau/dispnv04: fix null pointer dereference in nv17_tv_get_hd_modes 



commit 6d411c8ccc0137a612e0044489030a194ff5c843 upstream.

In nv17_tv_get_hd_modes(), the return value of drm_mode_duplicate() is
assigned to mode, which will lead to a possible NULL pointer dereference
on failure of drm_mode_duplicate(). The same applies to drm_cvt_mode().
Add a check to avoid null pointer dereference.

Cc: stable@vger.kernel.org
Signed-off-by: default avatarMa Ke <make24@iscas.ac.cn>
Signed-off-by: default avatarLyude Paul <lyude@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240625081029.2619437-1-make24@iscas.ac.cn


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 9289cd34

drivers/gpu/drm/nouveau/dispnv04/tvnv17.c

+4 −0
Original line number Original line Diff line number Diff line
@@ -259,6 +259,8 @@ static int nv17_tv_get_hd_modes(struct drm_encoder *encoder, 
		if (modes[i].hdisplay == output_mode->hdisplay &&

		if (modes[i].hdisplay == output_mode->hdisplay &&

		    modes[i].vdisplay == output_mode->vdisplay) {

		    modes[i].vdisplay == output_mode->vdisplay) {

			mode = drm_mode_duplicate(encoder->dev, output_mode);

			mode = drm_mode_duplicate(encoder->dev, output_mode);

			if (!mode)

				continue;

			mode->type |= DRM_MODE_TYPE_PREFERRED;

			mode->type |= DRM_MODE_TYPE_PREFERRED;





		} else {

		} else {
@@ -266,6 +268,8 @@ static int nv17_tv_get_hd_modes(struct drm_encoder *encoder, 
					    modes[i].vdisplay, 60, false,

					    modes[i].vdisplay, 60, false,

					    (output_mode->flags &

					    (output_mode->flags &

					     DRM_MODE_FLAG_INTERLACE), false);

					     DRM_MODE_FLAG_INTERLACE), false);

			if (!mode)

				continue;

		}

		}





		/* CVT modes are sometimes unsuitable... */

		/* CVT modes are sometimes unsuitable... */