Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9289cd34 authored by Ma Ke's avatar Ma Ke Committed by Greg Kroah-Hartman
Browse files

drm/nouveau/dispnv04: fix null pointer dereference in nv17_tv_get_ld_modes 



commit 66edf3fb331b6c55439b10f9862987b0916b3726 upstream.

In nv17_tv_get_ld_modes(), the return value of drm_mode_duplicate() is
assigned to mode, which will lead to a possible NULL pointer dereference
on failure of drm_mode_duplicate(). Add a check to avoid npd.

Cc: stable@vger.kernel.org
Signed-off-by: default avatarMa Ke <make24@iscas.ac.cn>
Signed-off-by: default avatarLyude Paul <lyude@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240625081828.2620794-1-make24@iscas.ac.cn


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 72152ab8

drivers/gpu/drm/nouveau/dispnv04/tvnv17.c

+2 −0
Original line number Original line Diff line number Diff line
@@ -208,6 +208,8 @@ static int nv17_tv_get_ld_modes(struct drm_encoder *encoder, 
		struct drm_display_mode *mode;

		struct drm_display_mode *mode;





		mode = drm_mode_duplicate(encoder->dev, tv_mode);

		mode = drm_mode_duplicate(encoder->dev, tv_mode);

		if (!mode)

			continue;





		mode->clock = tv_norm->tv_enc_mode.vrefresh *

		mode->clock = tv_norm->tv_enc_mode.vrefresh *

			mode->htotal / 1000 *

			mode->htotal / 1000 *