Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e9480b5a authored by Bjorn Helgaas's avatar Bjorn Helgaas
Browse files

PCI: hisi: Pass device-specific struct to internal functions 



Only interfaces used from outside the driver, e.g., those called by the
DesignWare core, need to accept pointers to the generic struct pcie_port.
Internal interfaces can accept pointers to the device-specific struct,
which makes them more straightforward.  No functional change intended.

Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
parent a458ce33

drivers/pci/host/pcie-hisi.c

+4 −4
Original line number Diff line number Diff line
@@ -126,13 +126,13 @@ static struct pcie_host_ops hisi_pcie_host_ops = { 
	.link_up = hisi_pcie_link_up,

};



static int hisi_add_pcie_port(struct pcie_port *pp,

static int hisi_add_pcie_port(struct hisi_pcie *hisi_pcie,

			      struct platform_device *pdev)

{

	struct pcie_port *pp = &hisi_pcie->pp;

	struct device *dev = pp->dev;

	int ret;

	u32 port_id;

	struct hisi_pcie *hisi_pcie = to_hisi_pcie(pp);



	if (of_property_read_u32(dev->of_node, "port-id", &port_id)) {

		dev_err(dev, "failed to read port-id\n");
@@ -190,7 +190,7 @@ static int hisi_pcie_probe(struct platform_device *pdev) 
		return PTR_ERR(pp->dbi_base);

	}



	ret = hisi_add_pcie_port(pp, pdev);

	ret = hisi_add_pcie_port(hisi_pcie, pdev);

	if (ret)

		return ret;