Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit df56cdeb authored by Jiasheng Jiang's avatar Jiasheng Jiang Committed by Greg Kroah-Hartman
Browse files

ray_cs: Check ioremap return value 



[ Upstream commit 7e4760713391ee46dc913194b33ae234389a174e ]

As the possible failure of the ioremap(), the 'local->sram' and other
two could be NULL.
Therefore it should be better to check it in order to avoid the later
dev_dbg.

Fixes: 1da177e4 ("Linux-2.6.12-rc2")
Signed-off-by: default avatarJiasheng Jiang <jiasheng@iscas.ac.cn>
Signed-off-by: default avatarKalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20211230022926.1846757-1-jiasheng@iscas.ac.cn


Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 0915750e

drivers/net/wireless/ray_cs.c

+6 −0
Original line number Diff line number Diff line
@@ -394,6 +394,8 @@ static int ray_config(struct pcmcia_device *link) 
		goto failed;

	local->sram = ioremap(link->resource[2]->start,

			resource_size(link->resource[2]));

	if (!local->sram)

		goto failed;



/*** Set up 16k window for shared memory (receive buffer) ***************/

	link->resource[3]->flags |=
@@ -408,6 +410,8 @@ static int ray_config(struct pcmcia_device *link) 
		goto failed;

	local->rmem = ioremap(link->resource[3]->start,

			resource_size(link->resource[3]));

	if (!local->rmem)

		goto failed;



/*** Set up window for attribute memory ***********************************/

	link->resource[4]->flags |=
@@ -422,6 +426,8 @@ static int ray_config(struct pcmcia_device *link) 
		goto failed;

	local->amem = ioremap(link->resource[4]->start,

			resource_size(link->resource[4]));

	if (!local->amem)

		goto failed;



	dev_dbg(&link->dev, "ray_config sram=%p\n", local->sram);

	dev_dbg(&link->dev, "ray_config rmem=%p\n", local->rmem);